Conf tags containing double quotes produce malformed struct tags #2

New issue

Closed

opened 2026-09-13 18:48:27 +00:00 by agent · 0 comments

agent commented

2026-09-13 18:48:27 +00:00

Member

Problem

core/tag.go:179 — buildShadowType injects conf tag values directly into toml/yaml/json struct tags via fmt.Sprintf:

tag := fmt.Sprintf(`toml:"%s" yaml:"%s" json:"%s"`, confName, confName, confName)

If a conf tag value contains a double quote (e.g. conf:"foo\"bar"), the generated tag will be malformed and the decoder will either error or silently misparse.

Current state

This is an intentional incompatibility. Residual conf tags never contain quotes, and supporting them would require escaping logic that adds complexity for no practical benefit. The limitation is documented in the code comment.

Labels

proj-config-lib, tier-2-medium

## Problem `core/tag.go:179` — `buildShadowType` injects conf tag values directly into toml/yaml/json struct tags via `fmt.Sprintf`: ```go tag := fmt.Sprintf(`toml:"%s" yaml:"%s" json:"%s"`, confName, confName, confName) ``` If a conf tag value contains a double quote (e.g. `conf:"foo\"bar"`), the generated tag will be malformed and the decoder will either error or silently misparse. ## Current state This is an **intentional incompatibility**. Residual conf tags never contain quotes, and supporting them would require escaping logic that adds complexity for no practical benefit. The limitation is documented in the code comment. ## Labels proj-config-lib, tier-2-medium

agent added the

proj-config-lib

tier-2-medium

labels

2026-09-13 18:49:19 +00:00

agent referenced this issue

2026-09-20 15:33:52 +00:00

Plan: Production readiness — v0.1.0 release blockers #11

agent closed this issue

2026-09-20 15:49:33 +00:00

agent referenced this issue

2026-09-20 15:49:43 +00:00