From fc6aa7cc1cb14e234bc3e7061d4b34b31f2df2ce Mon Sep 17 00:00:00 2001 From: caryoscelus Date: Wed, 5 Dec 2018 10:05:43 +0000 Subject: [PATCH 1/2] Minor fix in sidebar plugin Under certain conditions content["files"] is present, but is None, which led to exception and thus failure of the whole sidebar. --- plugins/Sidebar/SidebarPlugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/Sidebar/SidebarPlugin.py b/plugins/Sidebar/SidebarPlugin.py index 1ae47455..e4e77067 100644 --- a/plugins/Sidebar/SidebarPlugin.py +++ b/plugins/Sidebar/SidebarPlugin.py @@ -196,7 +196,7 @@ class UiWebsocketPlugin(object): contents = site.content_manager.listContents() # Without user files for inner_path in contents: content = site.content_manager.contents[inner_path] - if "files" not in content: + if "files" not in content or content["files"] is None: continue for file_name, file_details in content["files"].items(): size_total += file_details["size"] From 9454c05b7ea6f701f2fe09d7e38ea96a41b8f073 Mon Sep 17 00:00:00 2001 From: Thunder33345 Date: Thu, 13 Dec 2018 00:58:40 +0800 Subject: [PATCH 2/2] Added issue templates for suggestions (#1814) * Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/Bug Reports.md * Update issue templates * Rename Bug Reports.md to bugs.md * Update issue templates oh well apparently it only likes it if you use it's editor * Delete bug_report.md * Delete bugs.md --- .../bug-report.md} | 9 +++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++++++++ 2 files changed, 29 insertions(+) rename .github/{ISSUE_TEMPLATE.md => ISSUE_TEMPLATE/bug-report.md} (83%) create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE/bug-report.md similarity index 83% rename from .github/ISSUE_TEMPLATE.md rename to .github/ISSUE_TEMPLATE/bug-report.md index 1f2bab53..b97ad556 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -1,3 +1,12 @@ +--- +name: Bug report +about: Create a report to help us improve ZeroNet +title: '' +labels: '' +assignees: '' + +--- + ### Step 1: Please describe your environment * ZeroNet version: _____ diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..fe7c8178 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for ZeroNet +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here.