Reduce indent by using continue instead of if

This commit is contained in:
shortcutme 2017-10-03 16:04:03 +02:00
parent 6fe5e2b751
commit 49d863fa54
No known key found for this signature in database
GPG key ID: 5B63BAE6CB9613AE

View file

@ -44,50 +44,50 @@ class Worker(object):
self.manager.log.debug("%s: %s, picked task free after %ss sleep. (done: %s)" % (self.key, task["inner_path"], 0.1 * sleep_i, task["done"])) self.manager.log.debug("%s: %s, picked task free after %ss sleep. (done: %s)" % (self.key, task["inner_path"], 0.1 * sleep_i, task["done"]))
break break
if task["done"] is False: if task["done"]:
self.task = task continue
site = task["site"]
task["workers_num"] += 1 self.task = task
site = task["site"]
task["workers_num"] += 1
try:
buff = self.peer.getFile(site.address, task["inner_path"], task["size"])
except Exception, err:
self.manager.log.debug("%s: getFile error: %s" % (self.key, err))
buff = None
if self.running is False: # Worker no longer needed or got killed
self.manager.log.debug("%s: No longer needed, returning: %s" % (self.key, task["inner_path"]))
break
if task["done"] is True: # Task done, try to find new one
continue
if buff: # Download ok
try: try:
buff = self.peer.getFile(site.address, task["inner_path"], task["size"]) correct = site.content_manager.verifyFile(task["inner_path"], buff)
except Exception, err: except Exception, err:
self.manager.log.debug("%s: getFile error: %s" % (self.key, err))
buff = None
if self.running is False: # Worker no longer needed or got killed
self.manager.log.debug("%s: No longer needed, returning: %s" % (self.key, task["inner_path"]))
break
if task["done"] is True: # Task done, try to find new one
continue
if buff: # Download ok
try:
correct = site.content_manager.verifyFile(task["inner_path"], buff)
except Exception, err:
correct = False
else: # Download error
err = "Download failed"
correct = False correct = False
if correct is True or correct is None: # Verify ok or same file else: # Download error
self.manager.log.debug("%s: Verify correct: %s" % (self.key, task["inner_path"])) err = "Download failed"
if correct is True and task["done"] is False: # Save if changed and task not done yet correct = False
buff.seek(0) if correct is True or correct is None: # Verify ok or same file
site.storage.write(task["inner_path"], buff) self.manager.log.debug("%s: Verify correct: %s" % (self.key, task["inner_path"]))
if task["done"] is False: if correct is True and task["done"] is False: # Save if changed and task not done yet
self.manager.doneTask(task) buff.seek(0)
task["workers_num"] -= 1 site.storage.write(task["inner_path"], buff)
self.task = None if task["done"] is False:
else: # Verify failed self.manager.doneTask(task)
self.manager.log.debug( task["workers_num"] -= 1
"%s: Verify failed: %s, error: %s, failed peers: %s" % else: # Verify failed
(self.key, task["inner_path"], err, len(task["failed"])) task["workers_num"] -= 1
) self.manager.log.debug(
task["failed"].append(self.peer) "%s: Verify failed: %s, error: %s, failed peers: %s, workers: %s" %
self.task = None (self.key, task["inner_path"], err, len(task["failed"]), task["workers_num"])
self.peer.hash_failed += 1 )
if self.peer.hash_failed >= max(len(self.manager.tasks), 3) or self.peer.connection_error > 10: task["failed"].append(self.peer)
# Broken peer: More fails than tasks number but atleast 3 self.peer.hash_failed += 1
break if self.peer.hash_failed >= max(len(self.manager.tasks), 3) or self.peer.connection_error > 10:
task["workers_num"] -= 1 # Broken peer: More fails than tasks number but atleast 3
time.sleep(1) break
time.sleep(1)
self.peer.onWorkerDone() self.peer.onWorkerDone()
self.running = False self.running = False
self.manager.removeWorker(self) self.manager.removeWorker(self)